From 01742f13d725ba5b5b62143d7ad5c16077de9e48 Mon Sep 17 00:00:00 2001 From: oxmox Date: Sat, 18 Feb 2023 11:23:19 +0100 Subject: [PATCH] cmake: turn imgui from an INTERFACE library into an OBJECT library Saves us from compiling imgui multiple times and makes cmake invoked clang-tidy automatically skip the imgui header and implementation files because they are not directly part of our targets. --- external/CMakeLists.txt | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/external/CMakeLists.txt b/external/CMakeLists.txt index ace6d32..f042a51 100644 --- a/external/CMakeLists.txt +++ b/external/CMakeLists.txt @@ -2,11 +2,9 @@ option(NNG_SETSTACKSIZE "Use rlimit for thread stack size" ON) set(NNG_TESTS OFF) set(NNG_ENABLE_NNGCAT OFF) add_subdirectory(nng) - find_package(SDL2 REQUIRED) -add_library(imgui INTERFACE) -target_sources(imgui INTERFACE +add_library(imgui OBJECT ${CMAKE_CURRENT_SOURCE_DIR}/imgui/imgui.cpp ${CMAKE_CURRENT_SOURCE_DIR}/imgui/imgui_demo.cpp ${CMAKE_CURRENT_SOURCE_DIR}/imgui/imgui_draw.cpp @@ -16,5 +14,5 @@ target_sources(imgui INTERFACE ${CMAKE_CURRENT_SOURCE_DIR}/imgui/backends/imgui_impl_sdlrenderer.cpp ) -target_include_directories(imgui INTERFACE ${CMAKE_CURRENT_SOURCE_DIR}/imgui) -target_link_libraries(imgui INTERFACE SDL2::SDL2-static) \ No newline at end of file +target_include_directories(imgui PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/imgui) +target_link_libraries(imgui PUBLIC SDL2::SDL2-static) \ No newline at end of file