From dd939b480874a13537876de580889faf31e65404 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Florian=20L=C3=BCke?= <f.lueke@mesytec.com>
Date: Wed, 1 Jan 2025 18:21:52 +0100
Subject: [PATCH] add IManaBufferSink concept

---
 src/internal/mana_api.hpp     | 20 +++++++++++++++
 src/internal/mana_lib.hpp     | 48 +++++++++++++++++++++++++++++++++++
 src/internal/mana_nng.hpp     |  2 ++
 src/tools/mana_auto_replay.cc |  2 ++
 4 files changed, 72 insertions(+)

diff --git a/src/internal/mana_api.hpp b/src/internal/mana_api.hpp
index 654d0f8..37618df 100644
--- a/src/internal/mana_api.hpp
+++ b/src/internal/mana_api.hpp
@@ -31,6 +31,26 @@ class IManaSink
     IManaSink &operator=(const IManaSink &) = delete;
 };
 
+class IManaBufferSink
+{
+  public:
+    virtual ~IManaBufferSink() = default;
+
+    virtual void begin_run(const char *descriptor_json) = 0;
+    virtual void end_run(const char *descriptor_json) = 0;
+    // buffer is the same format as used in mana_nng.hpp. It starts with a MessageHeader::Eventdata
+    // structure.
+    virtual void process_event_buffer(const uint8_t *buffer, size_t size) = 0;
+    virtual void process_system_event(const uint32_t *data, size_t size) = 0;
+
+  protected:
+    IManaBufferSink() = default;
+
+  private:
+    IManaBufferSink(const IManaBufferSink &) = delete;
+    IManaBufferSink &operator=(const IManaBufferSink &) = delete;
+};
+
 class IManaPlugin
 {
   public:
diff --git a/src/internal/mana_lib.hpp b/src/internal/mana_lib.hpp
index d8363dd..c4a99d8 100644
--- a/src/internal/mana_lib.hpp
+++ b/src/internal/mana_lib.hpp
@@ -232,6 +232,54 @@ inline std::string to_string(const ManaSinkPerfProxy::Perf &perf)
                        totalHits, MiB, elapsed_s, hit_s, MiB_s);
 }
 
+#if 0
+class ManaBufferingSink: public IManaSink
+{
+  public:
+    using flush_predicate = std::function<bool()>;
+    explicit ManaBufferingSink(IManaBufferSink *dest, flush_predicate doFlush)
+        : dest_(dest)
+        , doFlush_(doFlush)
+    {
+    }
+
+    void begin_run(const char *descriptor_json) override { dest_->begin_run(descriptor_json); }
+
+    void end_run(const char *descriptor_json) override { dest_->end_run(descriptor_json); }
+
+    void process_event(uint16_t eventIndex, mana_offset_array_t *arrays, size_t arrayCount,
+                       size_t totalBytes) override
+    {
+    }
+
+    void process_system_event(const uint32_t *data, size_t size) override {}
+
+  private:
+    IManaBufferSink *dest_;
+    flush_predicate doFlush_;
+};
+
+class ManaDebufferingSink: public IManaBufferSink
+{
+  public:
+    explicit ManaDebufferingSink(IManaSink *dest)
+        : dest_(dest)
+    {
+    }
+
+    void begin_run(const char *descriptor_json) override { dest_->begin_run(descriptor_json); }
+
+    void end_run(const char *descriptor_json) override { dest_->end_run(descriptor_json); }
+
+    void process_event_buffer(const uint8_t *buffer, size_t size) override {}
+
+    void process_system_event(const uint32_t *data, size_t size) override {}
+
+  private:
+    IManaSink *dest_;
+};
+#endif
+
 struct mana_c_error: public std::exception
 {
     mana_status_t status;
diff --git a/src/internal/mana_nng.hpp b/src/internal/mana_nng.hpp
index f338adc..3e7c96f 100644
--- a/src/internal/mana_nng.hpp
+++ b/src/internal/mana_nng.hpp
@@ -29,8 +29,10 @@ struct EventDataHeader
     u32 sizeBytes;
 };
 
+// clang-format: off
 // EventData message layout: MessageHeader, repeated(EventDataHeader +
 // mana_offset_array_t[arrayCount])
+// clang-format: on
 
 class NngServerSink: public IManaSink
 {
diff --git a/src/tools/mana_auto_replay.cc b/src/tools/mana_auto_replay.cc
index cf175dd..12be797 100644
--- a/src/tools/mana_auto_replay.cc
+++ b/src/tools/mana_auto_replay.cc
@@ -246,6 +246,8 @@ struct NngPairStrategy: public ReplayStrategy
 
         while (!quit)
         {
+            // TODO: eliminate this buffer. read directly into an allocated nng_msg. do usb fixup in
+            // there.
             listfileContext.readerHelper.destBuf().clear();
             auto buffer = mvlc::listfile::read_next_buffer(listfileContext.readerHelper);